Skip to content

Generate with syntax kind bug fix #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2021

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented May 12, 2021

@ahoppen

I changed to endswith("token")and it seemed to generate correct (of what I understand).

swiftlang/swift#37382

@ahoppen
Copy link
Member

ahoppen commented May 14, 2021

swiftlang/swift#37382

@swift-ci Please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good.

@ahoppen ahoppen self-assigned this May 14, 2021
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5659e31

@ahoppen
Copy link
Member

ahoppen commented May 14, 2021

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5659e31

@ahoppen
Copy link
Member

ahoppen commented May 14, 2021

swiftlang/swift#37382

@swift-ci Please test Linux

@kimdv
Copy link
Contributor Author

kimdv commented May 14, 2021

@ahoppen it says 16:14:44 FAIL: Gyb-generated files committed to repository do not match generated ones. Please re-generate the gyb-files and recommit them.

But if I regenerate locally it don't change anything?

Should I rebase swiftlang/swift#37382 to latest master?

@ahoppen
Copy link
Member

ahoppen commented May 14, 2021

The first Linux PR testing failed for completely unrelated reasons, so I triggered it again. But in the second invocation I forgot to mention the PR in the main repo, so it was verifying the gyb-generated files against the current version in there (which obviously failed), so now I triggered Linux PR testing for a third time. I should have maybe mentioned that in the trigger comments.

@ahoppen ahoppen merged commit a1f929c into swiftlang:main May 14, 2021
@kimdv kimdv deleted the kimdv/generate-with-syntax-kind-fix branch May 19, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants