Skip to content

Add support for @lifetime(borrow ...) #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

meg-gupta
Copy link
Contributor

No description provided.

@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/swift#77466

@swift-ci Please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, just two minor comments.

func derive6(ne: borrowing NE, neOut: inout NE) -> NE { neOut = ne }
"""
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a test case for borrow blah in a normal expression position and one that ensure we parse borrow(blah), borrow (blah) as function calls?

@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/swift#77466

@swift-ci Please test

@meg-gupta
Copy link
Contributor Author

@swift-ci Please test

@meg-gupta meg-gupta enabled auto-merge November 8, 2024 18:48
@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test windows platform

@meg-gupta meg-gupta merged commit 3b939e0 into swiftlang:main Nov 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants