-
Notifications
You must be signed in to change notification settings - Fork 440
Add support for @lifetime(borrow ...) #2894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please test with following pull request: @swift-ci Please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM, just two minor comments.
func derive6(ne: borrowing NE, neOut: inout NE) -> NE { neOut = ne } | ||
""" | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a test case for borrow blah
in a normal expression position and one that ensure we parse borrow(blah)
, borrow (blah)
as function calls?
Please test with following pull request: @swift-ci Please test |
05d5d5f
to
bbf0023
Compare
@swift-ci Please test |
@swift-ci smoke test windows platform |
No description provided.