Use access levels on imports when compiler(>=6)
#2917
Merged
+168
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
DougGregor,
ahoppen and
bnbarham
as code owners
|
We should also consider enabling the upcoming |
tshortli
force-pushed
the
access-level-on-imports
branch
2 times, most recently
from
681cdcc to
1464815
Compare
|
@swift-ci please test |
|
@swift-ci Please test Windows |
tshortli
force-pushed
the
access-level-on-imports
branch
from
1464815 to
5d70fe6
Compare
|
I forgot to update code generation - fixed. |
|
@swift-ci please test |
|
Alright, as it turns out access level on import still requires a feature flag on 5.10. So I will update the |
Access levels on `import` declarations are a language feature that was introduced with the Swift 6 compiler but they don't depend on the Swift 6 language mode. `@_implementationOnly import` is now deprecated and `internal import` should be used instead, so SwiftSyntax's use of access levels on imports should depend on the compiler version, not the language version to ensure it no longer uses the `@_implementationOnly` unnecessarily. As a notable exception, `_SwiftSyntaxCShims` must continue to be imported `@_implementationOnly` since it's a local module that cannot be loaded by clients, and `internal import` does not hide modules from dependents when SwiftSyntax is built without library evolution.
tshortli
force-pushed
the
access-level-on-imports
branch
from
5d70fe6 to
1d1aded
Compare
tshortli
changed the title
compiler(>=5.10)compiler(>=6)
xymus
approved these changes
Dec 14, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access levels on
importdeclarations are a language feature that was introduced with the Swift 6 compiler but they don't depend on the Swift 6 language mode.@_implementationOnly importis now deprecated andinternal importshould be used instead, so SwiftSyntax's use of access levels on imports should depend on the compiler version, not the language version, to ensure it no longer uses@_implementationOnlyunnecessarily.As a notable exception,
_SwiftSyntaxCShimsmust continue to be imported@_implementationOnlysince it's a local module that cannot be loaded by clients, andinternal importdoes not hide modules from dependents when SwiftSyntax is built without library evolution.