[Syntax] Fix TriviaPiece.isNewline #2943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
triviapiece-trait
branch
from
12beca4 to
8924165
Compare
In Swift, only 'CR', 'LF', and 'CR+LF' are considered newline characters. `TriviaPiece.isNewline` should not return true for 'VT' and 'FF'. Instead of using 'Swift.Character.isNewline', introduce 'TriviaTraits' in CodeGeneration, and manually set them for each trivia piece kind.
Not sure how it was used, but it's not used anymore.
'String' is natually a collection of characters. Eliminate 'Trivia.CharactersLen' because 'Trivia.characters.utf8.count' is straightforward enough, and it was technically wrong because it returned character count, but not utf8 byte count.
rintaro
force-pushed
the
triviapiece-trait
branch
from
8924165 to
70b2819
Compare
|
@swift-ci Please test |
ahoppen
approved these changes
Jan 18, 2025
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift, only
CR,LF, andCR+LFare considered newline characters.TriviaPiece.isNewlineshould not return true forVTandFF.Instead of using
Swift.Character.isNewline, introduceTriviaTraitsin CodeGeneration, and manually set them for each trivia piece kind.Also some drive-by cleanups:
Trivia.swiftCharactersbecause it was unused.String?forToken.charactersbecause string is naturally a collection of characters.Trivia.CharactersLenbecauseTrivia.characters.utf8.countis straightforward enough, and it was technically wrong because it returned character count, but not UTF8 byte count.