Skip to content

Fix parsing package in @_documentation(visibility: package) #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Jan 24, 2025

Parsing attribute in @_documentation(visibility: package) public class A fails due to package not being recognized. This PR adds support for the access level in the argument to be parsed.

rdar://143869986

@elsh elsh requested review from ahoppen and bnbarham as code owners January 24, 2025 15:00
@elsh
Copy link
Contributor Author

elsh commented Jan 24, 2025

@swift-ci smoke test

@elsh elsh requested a review from nkcsgexi January 24, 2025 16:19
@elsh
Copy link
Contributor Author

elsh commented Jan 25, 2025

@swift-ci smoke test windows

@elsh
Copy link
Contributor Author

elsh commented Jan 28, 2025

@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Jan 29, 2025

@swift-ci test macOS linux

@elsh
Copy link
Contributor Author

elsh commented Jan 29, 2025

@swift-ci Please test

@tshortli
Copy link
Contributor

Is there anything preventing this from landing?

@nkcsgexi nkcsgexi merged commit d84bd2f into main Feb 17, 2025
3 checks passed
@nkcsgexi nkcsgexi deleted the elsh/at-documentation-with-package-arg branch February 17, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants