[SwiftSyntaxBuilder] Add support for control flow statements in result builders #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t builders Add the `buildOptional` etc. result builder constructs to add support for control-flow constructs inside the result builders.
|
@swift-ci Please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
…are true: * It is the type of a variable (file-, function-, or type-scoped) * It is mutable (`var`, not `let`) * It is not a computed property * It does not have an initializer expression If all of these are true, shortening it to `T?` would introduce a useless nil-initialization that can be problematic in situations that want to optimize performance (see https://forums.swift.org/t/what-is-a-variable-initialization-expression/52132). Fixes swiftlang#304.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
buildOptionaletc. result builder constructs to add support for control-flow constructs inside the result builders.CC: @czechboy0