Add convenience initializers function call expr

[kimdv]

A simple and small one that makes it a bit cleaner

[ahoppen]

Can’t we make IdentifierExpr conform to ExpressibleByStringLiteral for a more generic fix?

[kimdv]

It already is https://github.com/apple/swift-syntax/blob/3ea358da538c8c879d23a6b91f3e5f6edaac663f/Sources/SwiftSyntaxBuilder/IdentifierExprConvenienceInitializers.swift#L19

But FunctionCallExpr.calledExpression is a ExprBuildable and not a IdentifierExpr.
So it' can't make the correct type.

Or am I missing something?
We could also use IdentifierExpr instead of the String. That might do it?

Update:
A quick test: Changing calledExpression: String -> calledExpression: IdentifierExpr works.
I think that's a better solution.

[ahoppen]

Ah, sorry. I should have looked more closely, I thought FunctionCallExpr.calledExpression is an IdentifierExpr. Adding a convenience that takes an IdentifierExpr sounds good to me. Thanks

[kimdv]

No worries! I happens 😁

I have changed.
Would you mind to trigger the CI?

[ahoppen]

@swift-ci Please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 6f1ccd2

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 6f1ccd2