Skip to content

Add convenience initializers for MemberDeclList #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Nov 21, 2021

Waiting for #339 is merged

Protocols.py change PR: swiftlang/swift#40280

@kimdv kimdv force-pushed the kimdv/add-convenience-initializer-for-member-decl-list branch 2 times, most recently from b285c68 to b771bec Compare November 21, 2021 18:37
@kimdv kimdv marked this pull request as ready for review November 29, 2021 08:04
@kimdv kimdv force-pushed the kimdv/add-convenience-initializer-for-member-decl-list branch from b771bec to b383632 Compare November 29, 2021 08:07
@kimdv
Copy link
Contributor Author

kimdv commented Nov 29, 2021

swiftlang/swift#40280

@swift-ci Please test

@kimdv kimdv requested a review from ahoppen November 29, 2021 08:09
@ahoppen
Copy link
Member

ahoppen commented Nov 29, 2021

swiftlang/swift#40280

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b383632

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b383632

@kimdv kimdv force-pushed the kimdv/add-convenience-initializer-for-member-decl-list branch from b383632 to b771bec Compare November 29, 2021 14:12
@kimdv kimdv force-pushed the kimdv/add-convenience-initializer-for-member-decl-list branch from b771bec to e1159bd Compare November 29, 2021 14:18
@kimdv
Copy link
Contributor Author

kimdv commented Nov 29, 2021

swiftlang/swift#40280

@swift-ci Please test

1 similar comment
@ahoppen
Copy link
Member

ahoppen commented Nov 29, 2021

swiftlang/swift#40280

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b383632

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b383632

@kimdv kimdv merged commit 6859f75 into swiftlang:main Nov 29, 2021
@kimdv kimdv deleted the kimdv/add-convenience-initializer-for-member-decl-list branch November 29, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants