Skip to content

Add documentation to init methods #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Nov 27, 2021

I think it's worth adding documentation for init method, even not all parameters are documented (yet).

Maybe it could motivate us to add more documentation for the children. 🥳

@kimdv kimdv force-pushed the kimdv/add-documentation branch 3 times, most recently from c165ee6 to 8e898de Compare November 27, 2021 20:14
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@ahoppen
Copy link
Member

ahoppen commented Nov 29, 2021

@swift-ci Please test

@kimdv kimdv merged commit b20fd94 into swiftlang:main Nov 29, 2021
@kimdv kimdv deleted the kimdv/add-documentation branch March 24, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants