Add convenience initializer for ReturnClause
#345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Nov 30, 2021
|
|
||
| import SwiftSyntax | ||
|
|
||
| extension ReturnClause: ExpressibleByStringLiteral { |
There was a problem hiding this comment.
Do we actually need the ExpressibleByStringLiteral conformance? IIUC we should be able to use Strings for binary operators in all relevant places because we have String: ExpressibleAsReturnClause .
kimdv
force-pushed
the
kimdv/add-convenience-initializer-for-return-clause
branch
from
5ad7814 to
7e21e62
Compare
ahoppen
approved these changes
Dec 1, 2021
kimdv
force-pushed
the
kimdv/add-convenience-initializer-for-return-clause
branch
from
7e21e62 to
39e9447
Compare
|
@swift-ci Please test |
kimdv
deleted the
kimdv/add-convenience-initializer-for-return-clause
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.