Skip to content

Fix leading trivia is not applied if raw syntax is empty #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Feb 24, 2022

Not sure if we should create a test class for RawSyntax where we can add the test case, or it is enough with the current ones

@kimdv kimdv requested a review from ahoppen as a code owner February 24, 2022 18:47
@kimdv
Copy link
Contributor Author

kimdv commented Feb 24, 2022

@swift-ci Please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me. I think the current test coverage is fine. AFAICT we don’t have any tests at the RawSyntax level at the moment.

@kimdv kimdv force-pushed the kimdv/fix-not-passing-trivia branch from 1f6d784 to ac894cd Compare February 25, 2022 09:07
@kimdv kimdv requested a review from ahoppen February 25, 2022 09:07
@kimdv
Copy link
Contributor Author

kimdv commented Feb 25, 2022

@swift-ci Please test

@kimdv kimdv merged commit e4f7fc9 into swiftlang:main Feb 25, 2022
@kimdv kimdv deleted the kimdv/fix-not-passing-trivia branch March 24, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants