Skip to content

[5.6] rewrite swiftSettings to avoid causing SPM build failures #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

keith
Copy link
Member

@keith keith commented Mar 15, 2022

Cherry picked from #358

Fixes https://bugs.swift.org/browse/SR-15989

@keith
Copy link
Member Author

keith commented Mar 15, 2022

@swift-ci please test

@ahoppen
Copy link
Member

ahoppen commented Mar 17, 2022

Thanks for the fix. We are currently investigating the best procedure to create a hot fix release for SwiftSyntax with this change. I hope to have an answer and be able to create a 0.50600.1 release of SwiftSyntax in the next couple of days.

Copy link
Member

@airspeedswift airspeedswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for 5.6 because even though that release has shipped, this fixes compatibility when building from source.

@ahoppen ahoppen merged commit 3ee10cc into swiftlang:release/5.6 Mar 18, 2022
@ahoppen
Copy link
Member

ahoppen commented Mar 18, 2022

Thanks a lot for noticing the issue and providing this PR so quickly after the 0.50600.0 release of SwiftSyntax. I have just published a 0.50600.1 release that includes this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants