Adding SwiftSyntaxBuilder to the build process #379
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build process of SwiftSyntax, should build three shared objects:
The SwiftSyntaxBuilder one has not been called to be built, then this pull request adds such build call to the
build-script.py
file. Also, there are two points in the build process that was producing erros during the SwiftSyntaxBuilder build.string_escape
encode. However, python2 strings supports encoding forutf-8
and decoding asunicode_escape
.I'm not sure about differences between
string.encode('utf-8').decode('unicode_escape')
andstring.decode('string_escape')
in Python2, but looking for the data that will be used to fillTokens.swift.gyb
we only have UTF-8 characters, and for that case these approaches are equivalent. See the values in the file swift/utils/gyb_syntax_support/Token.py.