Skip to content

Support open in swiftSyntaxBuilder #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

iMostfa
Copy link
Contributor

@iMostfa iMostfa commented Apr 11, 2022

This pull request adds support for the 'open' keyword as TokenSyntax in SwiftSyntaxBuilder
it's implemented as syntactic sugar based on makeContextualKeyword
and accessed in swift like this: TokenSyntax.public

I'm open to your feedback and suggestation to enhance my pull request

greetings, Mostfa.

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good to me. Just one minor comment inline.

@iMostfa iMostfa force-pushed the Add-open-in-swiftSyntaxBuilder branch from 51fb4cb to a248664 Compare April 12, 2022 12:29
@iMostfa iMostfa force-pushed the Add-open-in-swiftSyntaxBuilder branch from a248664 to bee933f Compare April 12, 2022 12:34
@iMostfa
Copy link
Contributor Author

iMostfa commented Apr 12, 2022

Thank you @ahoppen
i've added your comment in Token.swift.gyb and the generated file

@ahoppen
Copy link
Member

ahoppen commented Apr 12, 2022

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented Apr 12, 2022

Thanks for the PR and welcome to SwiftSyntax development.

@ahoppen ahoppen merged commit 1dd7332 into swiftlang:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants