Show the command that needs to be run when SwiftSyntax files don't match #449
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
reviewed
May 23, 2022
build-script.py
Outdated
| "gyb-files and recommit them." | ||
| "gyb-files using the following command, open a PR to the " | ||
| "SwiftSyntax project and merge it alongside the main PR." | ||
| "$ swift-syntax/build-script.py --degyb-only --toolchain whatever" |
There was a problem hiding this comment.
Not sure if there's a brief way to say this, but it could be worth noting that it doesn't need to be a toolchain. Ie. /path/to/swift-build/ will generally work.
Even if you don't, I think something pathy instead of "whatever" would be better. Eg. /path/to/toolchain
There was a problem hiding this comment.
What do you think about the following?
swift-syntax/build-script.py --degyb-only --toolchain /dev/null
There was a problem hiding this comment.
Ah. I did not realize that the toolchain didn't matter. If that's too hard to fix my preference would be "ignored".
ahoppen
force-pushed
the
pr/document-degyb-only-command
branch
from
c76eba6 to
107f29e
Compare
This error message will show up if someone modifies the syntax definition files in the main swift repo without modifying the generated SwiftSyntax files accordingly. Tell them what to do in order to fix the problem. rdar://89777232
ahoppen
force-pushed
the
pr/document-degyb-only-command
branch
from
107f29e to
701443d
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
May 23, 2022
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Support CommandPlugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error message will show up if someone modifies the syntax definition files in the main swift repo without modifying the generated SwiftSyntax files accordingly. Tell them what to do in order to fix the problem.
rdar://89777232