Builder based initializer for DictionaryExpr
#455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ahoppen
reviewed
Jun 7, 2022
There was a problem hiding this comment.
This looks good but I think there’s a slight mismatch between PR title, description in code. AFAICT
- The description mentions “Allow to use ArrayType and DictionaryType as PatternBinding.typeAnnotation argument” covers all changes except DictionaryExprConvenienceInitializers.swift. These changes are looking great. ✅
- The title “Builder based initializer for DictionaryExpr” covers the changes in DictionaryExprConvenienceInitializers.swift. It would be good to have test coverage for those before merging. Maybe we can just cherry-pick the test case from #454.
Allow to use `ArrayType` and `DictionaryType` as `PatternBinding.typeAnnotation` argument
|
My intention was to avoid adding trailing commas, so I won't need to remove them in #454, but that's fine as well |
ahoppen
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Thanks. Looks good 👍
I just prefer to keep the PRs isolated so we can’t forget to add the test case if for some reason we should decide to take a different direction on the other PR. It also makes for a nicer git history where you can see the test cases that were added for a particular code change.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use
ArrayTypeandDictionaryTypeasPatternBinding.typeAnnotationargument