Skip to content

Proper indentation and line breaks for Switch/Case and Closure #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

evnik
Copy link
Contributor

@evnik evnik commented Jun 14, 2022

No description provided.

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC you edited the files in the gyb_generated manually. The next time we re-generate those, the changes will be overwritten. You would need to find a way to make these changes in the corresponding .swift.gyb files and then trigger generation of these files using ./build-script.py --degyb-only --toolchain /does/not/matter.

@evnik
Copy link
Contributor Author

evnik commented Jun 14, 2022

I didn't change those files manually. Please check related swiftlang/swift#59430 for changes in the sources used to generate files in the gyb_generated

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn’t see that PR. Could you mention any matching apple/swift PRs in the PR’s description next time so I don’t miss it again?

@ahoppen
Copy link
Member

ahoppen commented Jun 14, 2022

swiftlang/swift#59430

@swift-ci Please test

@ahoppen ahoppen self-assigned this Jun 14, 2022
@kimdv kimdv merged commit e6e1e3e into swiftlang:main Jun 16, 2022
@evnik evnik deleted the FormatImprovements branch June 16, 2022 13:54
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants