Skip to content

Generate Node, Child, Classification, NodeSerializationCodes, Traits and Trivia #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2022
Merged

Generate Node, Child, Classification, NodeSerializationCodes, Traits and Trivia #469

merged 1 commit into from
Jun 30, 2022

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Jun 18, 2022 •
edited
Loading

@kimdv kimdv changed the title Generate SwiftSyntaxBuilder @resultBuilders with SwiftSyntaxBuilder Generate SwiftSyntaxBuilders @resultBuilders with SwiftSyntaxBuilder Jun 18, 2022
@kimdv kimdv force-pushed the kimdv/generate-result-builder branch 8 times, most recently from 70105da to 810d6ff Compare June 19, 2022 20:18
@kimdv kimdv changed the title Generate SwiftSyntaxBuilders @resultBuilders with SwiftSyntaxBuilder Generate Node, Child, Classification, NodeSerializationCodes, Traits and Trivia Jun 25, 2022
@kimdv kimdv force-pushed the kimdv/generate-result-builder branch 4 times, most recently from 78cfaf1 to da967b2 Compare June 25, 2022 18:50
kimdv
kimdv commented Jun 25, 2022
View reviewed changes
@kimdv kimdv force-pushed the kimdv/generate-result-builder branch from da967b2 to 272b510 Compare June 25, 2022 19:03
@kimdv kimdv mentioned this pull request Jun 25, 2022
Merged
@kimdv kimdv marked this pull request as ready for review June 25, 2022 19:04
@kimdv kimdv requested a review from ahoppen as a code owner June 25, 2022 19:04
ahoppen
ahoppen reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is a big step to bootstrap the rest of SwiftSyntaxBuilder. I’ve got quite a few comments inline but they should all be minor.

Also, I think that all the types should be internal instead of public because they are only meant to be used in SwiftSyntaxBuilderGeneration for now.

@kimdv kimdv force-pushed the kimdv/generate-result-builder branch 3 times, most recently from 58541e9 to 4ec37cf Compare June 27, 2022 17:03
@kimdv
Copy link
Contributor Author

kimdv commented Jun 27, 2022

@ahoppen I've pushed the changes and suggestions you had.
Left two comments open for discussion.

@kimdv kimdv requested a review from ahoppen June 27, 2022 17:05
@kimdv kimdv force-pushed the kimdv/generate-result-builder branch 2 times, most recently from 8463d8b to fa92555 Compare June 27, 2022 17:08
ahoppen
ahoppen reviewed Jun 28, 2022
View reviewed changes
Sources/SwiftSyntaxBuilderGeneration/gyb_generated/AvailabilityNodes.swift Outdated
description: "A single argument to an `@available` argument like `*`, `iOS 10.1`,or `message: \"This has been deprecated\"`.",
kind: "Syntax",
children: [
Child(name: "Entry",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently indented by one space, it should probably be two.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the indentation from Xcode, and afterwards adjusted the gyb to it.

It might be something in Xcode then 🤷‍♂️

Will change.
Should the wrong indent bug be reported ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a reproducer in Xcode, it would be great if you could file a bug report on http://feedbackassistant.apple.com.

Copy link
Contributor Author

@kimdv kimdv Jun 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added feedback: FB10505542

Copy link
Member

@ahoppen ahoppen Jun 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing the feedback 👍

ahoppen
ahoppen reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed one comment from the first review. I’ve got a couple more minor comments. I think this is almost ready to be merged.

@kimdv kimdv force-pushed the kimdv/generate-result-builder branch from fa92555 to 3f36e6c Compare June 29, 2022 19:58
@kimdv kimdv force-pushed the kimdv/generate-result-builder branch from 3f36e6c to a411ee9 Compare June 29, 2022 20:01
@kimdv kimdv force-pushed the kimdv/generate-result-builder branch from a411ee9 to 6d45d60 Compare June 29, 2022 20:01
@kimdv
Copy link
Contributor Author

kimdv commented Jun 29, 2022

swiftlang/swift#59707

@swift-ci please test

@kimdv kimdv merged commit e4585a7 into swiftlang:main Jun 30, 2022
@kimdv kimdv deleted the kimdv/generate-result-builder branch June 30, 2022 09:06
@kimdv kimdv mentioned this pull request Jul 2, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimdv @ahoppen