Convenience initializer for TupleExprElement #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
reviewed
Jun 29, 2022
| public extension TupleExprElement { | ||
| /// A convenience initializer that allows passing in label as an optional string. | ||
| /// The presence of the colon will be inferred based on the presence of the label. | ||
| init(_ label: String? = nil, expression: ExpressibleAsExprBuildable) { |
There was a problem hiding this comment.
I don’t have super strong opinions but I think I would prefer label to be a labelled argument instead of an unlabelled one. What was your reasoning for making it unlabeled?
There was a problem hiding this comment.
Just wanted to make the signature different to the existing one, but I'm fine to make it labelled
|
@swift-ci Please test |
ahoppen
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.