Add convenience initializers that conforms to ExpressibleAsArrayExpr
#483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/add-convenience-initializers
branch
2 times, most recently
from
f27779f to
d58ae62
Compare
|
@swift-ci please test |
ahoppen
previously approved these changes
Jul 7, 2022
ahoppen
reviewed
Jul 7, 2022
Sources/SwiftSyntaxBuilder/ArrayElementListConvenienceInitializers.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftSyntaxBuilder/ArrayElementConvenienceInitializers.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/add-convenience-initializers
branch
2 times, most recently
from
a7eb28f to
97d1a59
Compare
kimdv
force-pushed
the
kimdv/add-convenience-initializers
branch
from
97d1a59 to
f93dd27
Compare
|
@swift-ci please test |
|
@ahoppen, there was to much spacing so cleaned a bit too 🧹 |
ahoppen
approved these changes
Aug 4, 2022
fwcd
reviewed
Aug 4, 2022
Comment on lines
-174
to
-178
| extension Array: ExpressibleAsArrayElementList where Element == ExpressibleAsArrayElement { | ||
| public func createArrayElementList() -> ArrayElementList { | ||
| return ArrayElementList(self) | ||
| } | ||
| } |
There was a problem hiding this comment.
Hm, this removes the Array: ExpressibleAsArrayElementList conformance since ExpressibleAsArrayElementList now has a superprotocol (see #528 for details why generating Array conformances for these hierarchies is hard).
But I guess we can just use ArrayElementLists instead of ArrayExprs in those places now (or simply the builder-based initializer for ArrayExpr).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #479