[Syntax] Clean up syntax grammar for declaration nodes #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
force-pushed
the
syntax-decl-cleanup
branch
from
2f48938 to
97c2039
Compare
DougGregor
force-pushed
the
syntax-decl-cleanup
branch
from
97c2039 to
c5561df
Compare
|
Tested via swiftlang/swift#60052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collected cleanups for the declaration grammar used by SwiftSyntax/libSyntax:
ActorDeclinto its own syntax node, separate fromClassDeclFunctionSignaturefor initializers rather than its own parameter clause, which picks up (e.g.) proper support for async and the experimental reasync, and also unifies their parameter lists with that of function declarationsTypeAliasDecl's initializer (the= type) is not optional, so remove its optionality