Skip to content

Return non-zero exit code in build-script.py if source generation fails #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

Return non-zero exit code in build-script.py if source generation fails #513

merged 1 commit into from
Jul 25, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 24, 2022

Previously, build-script.py would return with a zero exit code, even if source generation failed.

@ahoppen ahoppen requested a review from kimdv July 24, 2022 15:13
@ahoppen
Copy link
Member Author

ahoppen commented Jul 24, 2022

@swift-ci Please smoke test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 24, 2022

@swift-ci Please test

@ahoppen ahoppen merged commit ba64513 into swiftlang:main Jul 25, 2022
@ahoppen ahoppen deleted the pr/fail-if-source-generation-fails branch July 25, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimdv kimdv kimdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @kimdv