Allow putting garbage nodes in between any two children of a Syntax node #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/garbage-syntax
branch
from
1dfd8c2 to
64f778d
Compare
ahoppen
force-pushed
the
pr/garbage-syntax
branch
3 times, most recently
from
73be2a6 to
890ec4b
Compare
|
I presume we'll come around and clean up the places we're allowing you to stick garbage explicitly in the tree then?
|
CodaFi
approved these changes
Aug 1, 2022
|
Yes, I wanted to do that in a follow-up PR to keep this one focused. |
ahoppen
force-pushed
the
pr/garbage-syntax
branch
from
890ec4b to
121a430
Compare
rintaro
approved these changes
Aug 2, 2022
ahoppen
force-pushed
the
pr/garbage-syntax
branch
from
121a430 to
befe26f
Compare
ahoppen
force-pushed
the
pr/garbage-syntax
branch
from
befe26f to
857aede
Compare
If the `garbage` parameters in the SyntaxFactory are labelled, it’s not possible to specify e.g. the second garbage node but leave the others to their default (swiftlang/swift#60274). We could either give these `garbage` parameters distinct names or make them unlabeled to work around that issue. I chose to go for the unlabeled approach because it should be clear that these parameters contain garbage because of their type.
ahoppen
force-pushed
the
pr/garbage-syntax
branch
from
857aede to
1258671
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of swiftlang/swift#60211