Introduce a source accurate and structural view of a SwiftSyntax tree #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/syntax-tree-view-mode
branch
from
5eebcdd to
714ab5e
Compare
|
swiftlang/swift-stress-tester#181 @swift-ci Please test |
bnbarham
reviewed
Jul 27, 2022
ahoppen
force-pushed
the
pr/syntax-tree-view-mode
branch
from
714ab5e to
3dd2e2b
Compare
|
I made two changes to the PR:
|
|
swiftlang/swift-stress-tester#181 @swift-ci Please test |
ahoppen
force-pushed
the
pr/syntax-tree-view-mode
branch
from
3dd2e2b to
3ef5682
Compare
|
swiftlang/swift-stress-tester#181 @swift-ci Please test |
`SyntaxTreeViewMode` allows two different views on a SwiftSyntax tree: 1. Either a purely `sourceAccurate` view, which skips over all missing children but traverses garbage syntax (once implemented). This mode is intended for clients that operate at the source code level, like swift-format 2. For clients that don’t care about 100% about source fidelity but would like to view the syntax tree for structural analysis with fixes from the parser applied, there’s the `fixedUp` view. This includes missing nodes (because the user probably meant to write these) and skips over garbage nodes (because the client will likely have a hard time reasoning about these nodes if the parser couldn’t make sense of them)
ahoppen
force-pushed
the
pr/syntax-tree-view-mode
branch
from
3ef5682 to
cd7ded2
Compare
|
@swift-ci Please test |
|
swiftlang/swift-stress-tester#181 @swift-ci Please test |
|
I think this PR accidentally reverted the rename from |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyntaxTreeViewModeallows two different views on a SwiftSyntax tree:sourceAccurateview, which skips over all missing children but traverses garbage syntax (once implemented). This mode is intended for clients that operate at the source code level, like swift-formatfixedUpview. This includes missing nodes (because the user probably meant to write these) and skips over garbage nodes (because the client will likely have a hard time reasoning about these nodes if the parser couldn’t make sense of them)