Skip to content

Fix documentation for syntax collections in SwiftSyntaxBuilderGeneration #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Aug 4, 2022

The Swift translation ofNode.documentation (from the Python version) generates empty documentations for syntax collections without a documentation, which previously generated the description of its element type as a fallback. This small patch fixes this slight mistranslation.

@fwcd fwcd requested a review from ahoppen as a code owner August 4, 2022 02:38
@fwcd
Copy link
Member Author

fwcd commented Aug 4, 2022

@swift-ci please test

@fwcd fwcd merged commit 413fe13 into swiftlang:main Aug 4, 2022
@fwcd fwcd deleted the fix-node-documentation branch August 4, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants