Use NilLiteralExpr in BuildableCollectionNodes
#552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
AFAICT that’s because keywords require a trailing space by default. We might want to revisit that for literals. |
2 tasks
evnik
reviewed
Aug 5, 2022
Sources/SwiftSyntaxBuilderGeneration/Templates/BuildableCollectionNodesFile.swift
Show resolved
Hide resolved
fwcd
force-pushed
the
nil-literal-expr-buildable-collection-nodes
branch
from
a367672 to
6c1fedb
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small patch that uses
NilLiteralExprinBuildableCollectionNodesinstead of generatingnilas an identifier.One minor thing that we might want to figure out is why
niltokens generate a trailing space unlike identifier tokens.