Restore the Ability to Build with 5.6/5.5 #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still support building with tools from Xcode 13, so we cannot adopt features after Swift 5.5. Recreate UMRP.alignedUp(toMultipleOf:) for this environment and conditionalize docc support in the build script on the newer language features being around.
|
@swift-ci test |
CodaFi
commented
Aug 5, 2022
| @@ -142,9 +142,11 @@ let package = Package( | |||
| ] | |||
| ) | |||
|
|
|||
| // If `SWIFTCI_USE_LOCAL_DEPS` is set, we are in a CI enviornment that might disallow | |||
| #if swift(>=5.6) | |||
There was a problem hiding this comment.
I don't understand why we have this dependency. We do not need swift-docc-plugin to use docc, just the 5.5 package manifest or later. I would like to remove it.
There was a problem hiding this comment.
I thought that we needed it to build/preview the documentation using the following command. But maybe I’m missing something.
swift package --disable-sandbox preview-documentation --target SwiftSyntax
CC @kimdv
CodaFi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still support building with tools from Xcode 13, so we cannot adopt
features after Swift 5.5. Recreate UMRP.alignedUp(toMultipleOf:) for
this environment and conditionalize docc support in the build script
on the newer language features being around.