Skip to content

Add typed raw syntax nodes #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Add typed raw syntax nodes #572

merged 2 commits into from
Aug 12, 2022

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Aug 11, 2022

  • RawXXXSyntax is a typed RawSyntax providing SyntaxKind specific API including a factory initializer.
  • Expose RawSyntax, RawXXXSyntax, and other related types as SPI (@_spi(RawSyntax))
  • Move layout validation to RawSyntax and perform it whenever the layout is created. (debug build only). Previously, layout validation was only performed In SyntaxRewriter

@rintaro rintaro requested a review from ahoppen as a code owner August 11, 2022 06:24
@rintaro
Copy link
Member Author

rintaro commented Aug 11, 2022

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Aug 11, 2022

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Aug 11, 2022

@swift-ci Please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor comments inline.

@rintaro rintaro force-pushed the typedrawsyntax branch 2 times, most recently from f9bda3b to 4c88d34 Compare August 12, 2022 18:05
* RawXXXSyntax is a typed RawSyntax providing SyntaxKind specific API including
  a factory initializer.
* Expose RawSyntax, RawXXXSyntax, and other related types as SPI (RawSyntax)
Validate the layout whenever the layout node is created.
@rintaro
Copy link
Member Author

rintaro commented Aug 12, 2022

@swift-ci Please test

@rintaro rintaro merged commit 3b566c3 into swiftlang:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants