Skip to content

No longer require trailing space after expression-like keywords #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Aug 11, 2022

Companion PR to swiftlang/swift#60502.

@fwcd
Copy link
Member Author

fwcd commented Aug 11, 2022

swiftlang/swift#60502

@swift-ci please test

@fwcd fwcd force-pushed the gyb-syntax-keyword-trailing-space branch from d2a231f to 41349c5 Compare August 11, 2022 15:37
@fwcd
Copy link
Member Author

fwcd commented Aug 11, 2022

swiftlang/swift#60502

@swift-ci please test

@fwcd fwcd force-pushed the gyb-syntax-keyword-trailing-space branch from 41349c5 to 41546ad Compare August 11, 2022 15:41
@fwcd
Copy link
Member Author

fwcd commented Aug 11, 2022

swiftlang/swift#60502

@swift-ci please test

@ahoppen
Copy link
Member

ahoppen commented Aug 11, 2022

I modified BuildableCollectionNodes to no longer use SyntaxFactory, so I think you need to rebase on top of that.

@fwcd fwcd force-pushed the gyb-syntax-keyword-trailing-space branch from 41546ad to 23c6e1a Compare August 11, 2022 21:19
@fwcd
Copy link
Member Author

fwcd commented Aug 11, 2022

swiftlang/swift#60502

@swift-ci please test

1 similar comment
@fwcd
Copy link
Member Author

fwcd commented Aug 11, 2022

swiftlang/swift#60502

@swift-ci please test

@fwcd fwcd merged commit 2ce3e70 into swiftlang:main Aug 12, 2022
@fwcd fwcd deleted the gyb-syntax-keyword-trailing-space branch August 12, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants