Improve assert statement generation and fix token choices #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
commented
Aug 11, 2022
Comment on lines
104
to
106
| mappedTokenChoices.append(contentsOf: tokenChoices.compactMap { SYNTAX_TOKEN_MAP[$0] }) | ||
| self.tokenChoices = mappedTokenChoices | ||
| mappedTokenChoices.append(contentsOf: tokenChoices.map { SYNTAX_TOKEN_MAP["\($0)Token"] }) |
There was a problem hiding this comment.
This fixes a bug where self.tokenChoices was always empty since the tokenChoices do not have the Token suffix.
|
@swift-ci please test |
2 tasks
fwcd
force-pushed
the
improve-assert-stmt-generation
branch
2 times, most recently
from
f5f167a to
4de056e
Compare
ahoppen
reviewed
Aug 11, 2022
Sources/SwiftSyntaxBuilderGeneration/SyntaxBuildableChild.swift
Outdated
Show resolved
Hide resolved
fwcd
force-pushed
the
improve-assert-stmt-generation
branch
from
4de056e to
3dae647
Compare
ahoppen
approved these changes
Aug 12, 2022
fwcd
force-pushed
the
improve-assert-stmt-generation
branch
from
3dae647 to
ebfa2af
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #555, this patch migrates
generateAssertStmtTextChoicesto return an expr node instead of a string (as a small follow-up to #542). Additionally, it adds a utility function for escaping string literals (to address #549) and a function for generating force-unwraps based on a type's optionality.