Skip to content

Remove redundant assertion for cyclic SyntaxArenas #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Sources/SwiftSyntax/SyntaxArena.swift
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,7 @@ public class SyntaxArena {
precondition(
!self.hasParent,
"an arena can't have a new child once it's owned by other arenas")
// `precondition(!self.hasParent)` should be sufficient to make sure we
// don’t add retain cycles between syntax arenas, but to be doubly sure,
// check the child arenas as well in debug builds.
assert(!other.contains(arena: self), "cyclic arena hierarchy detected")


other.hasParent = true
children.insert(other)
}
Expand Down