Skip to content

Rename SwiftSyntaxBuilderGeneration to generate-swift-syntax-builder #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Aug 12, 2022

As suggested in #580 (comment). This follows the convention that executable targets are named in kebab-case (e.g. like this repo's lit-test-helper, SourceKit-LSP's sourcekit-lsp, SwiftFormat's swift-format, ...).

@fwcd fwcd requested a review from ahoppen as a code owner August 12, 2022 17:16
@fwcd
Copy link
Member Author

fwcd commented Aug 12, 2022

@swift-ci please test

@ahoppen
Copy link
Member

ahoppen commented Aug 12, 2022

Actually, now that I read the name, what do you think about making it more descriptive and name it generate-swift-syntax-builder?

@fwcd fwcd force-pushed the rename-syntax-gen branch from 10663fc to 2bcf5ed Compare August 12, 2022 17:29
@fwcd fwcd force-pushed the rename-syntax-gen branch from 2bcf5ed to 06b726e Compare August 12, 2022 17:33
@fwcd
Copy link
Member Author

fwcd commented Aug 12, 2022

Done!

@swift-ci please test

@fwcd
Copy link
Member Author

fwcd commented Aug 12, 2022

@swift-ci please test

@fwcd fwcd changed the title Rename SwiftSyntaxBuilderGeneration to kebab-case Rename SwiftSyntaxBuilderGeneration to generate-swift-syntax-builder Aug 12, 2022
@fwcd fwcd merged commit 0dce09f into swiftlang:main Aug 14, 2022
@fwcd fwcd deleted the rename-syntax-gen branch August 14, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants