SyntaxText: improve SyntaxText.== function #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
changed the title
rintaro
force-pushed
the
syntaxtext-equals
branch
2 times, most recently
from
25dee45 to
79f7628
Compare
|
@swift-ci Please test |
ahoppen
approved these changes
Aug 16, 2022
Since comparing the same memory region is rare in SwiftSyntax, drop the shortcut to save the execution branching.
rintaro
force-pushed
the
syntaxtext-equals
branch
from
79f7628 to
dadd43f
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since comparing the same memory region is rare in SwiftSyntax, drop the same-address shortcut to save the execution branching.
(For those who are interested this is how
RawTokenKind.init(keyword: SyntaxString)is compiled with-O)