Add a recursive hasError flag to RawSyntax
#596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
commented
Aug 16, 2022
Sources/SwiftSyntax/RawSyntax.swift
Outdated
| @@ -172,6 +174,13 @@ extension RawSyntax { | |||
| kind.isUnknown | |||
| } | |||
|
|
|||
| var hasError: Bool { | |||
| switch rawData.payload { | |||
| case .materializedToken(_): return self.presence == .missing | |||
There was a problem hiding this comment.
I would prefer to detect the presence of the node purely based on the materializedToken but I’m worried that will break if we change whether tokens without source text but with trivia are considered missing.
rintaro
reviewed
Aug 16, 2022
rintaro
reviewed
Aug 16, 2022
|
@swift-ci Please test |
rintaro
reviewed
Aug 16, 2022
|
I realized that we might need/want this flag in |
|
@swift-ci Please test |
rintaro
reviewed
Aug 17, 2022
| @@ -172,6 +187,19 @@ extension RawSyntax { | |||
| kind.isUnknown | |||
| } | |||
|
|
|||
| var recursiveFlags: RecursiveRawSyntaxFlags { | |||
| switch rawData.payload { | |||
There was a problem hiding this comment.
Since I merged ParsedToken PR, this switch needs to handle it. Sorry 🙇
This allows us to check whether a subtree contains a syntax error in O(1). rdar://98575249
|
@swift-ci Please test |
rintaro
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to check whether a subtree contains a syntax error in O(1).
rdar://98575249