Skip to content

Add recursiveDescription to RawSyntaxNodeProtocol #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 17, 2022

Having recursiveDescription is really useful for debugging purposes.

@ahoppen ahoppen requested a review from rintaro August 17, 2022 09:51
@ahoppen
Copy link
Member Author

ahoppen commented Aug 17, 2022

@swift-ci Please test

@rintaro
Copy link
Member

rintaro commented Aug 17, 2022

Oh RawSyntax also has debugWrite(to:indent:withChildren) method. Maybe we should unify them?

@rintaro
Copy link
Member

rintaro commented Aug 17, 2022

FWIW, I usually use dump(node.raw) for debugging.

Having `recursiveDescription` is really useful for debugging purposes.
@ahoppen ahoppen force-pushed the pr/raw-recursive-description branch from 1d0ad16 to d87b590 Compare August 18, 2022 07:45
@ahoppen
Copy link
Member Author

ahoppen commented Aug 18, 2022

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Aug 18, 2022

@swift-ci Please test macOS

@ahoppen ahoppen merged commit 4da1457 into swiftlang:main Aug 23, 2022
@ahoppen ahoppen deleted the pr/raw-recursive-description branch August 23, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants