Remove SyntaxFactory #607
Closed
Remove SyntaxFactory #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializers on types should be used in place of `SyntaxFactory`.
ahoppen
force-pushed
the
pr/remove-syntax-factory
branch
from
212c176 to
1f48c2d
Compare
|
@swift-ci Please test |
|
Can we keep these around for a while as @available(*, unavailable, message: "Use initializer on FunctionDeclSyntax")
public static func makeFunctionDecl(_: UnexpectedNodesSyntax? = nil, attributes: AttributeListSyntax?, _: UnexpectedNodesSyntax? = nil, modifiers: ModifierListSyntax?, _: UnexpectedNodesSyntax? = nil, funcKeyword: TokenSyntax, _: UnexpectedNodesSyntax? = nil, identifier: TokenSyntax, _: UnexpectedNodesSyntax? = nil, genericParameterClause: GenericParameterClauseSyntax?, _: UnexpectedNodesSyntax? = nil, signature: FunctionSignatureSyntax, _: UnexpectedNodesSyntax? = nil, genericWhereClause: GenericWhereClauseSyntax?, _: UnexpectedNodesSyntax? = nil, body: CodeBlockSyntax?) -> FunctionDeclSyntax {
preconditionFailure()
}It seems many projects are using them |
|
Thanks for checking. Let’s keep it around as deprecated for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift-stress-tester#186
Initializers on types should be used in place of
SyntaxFactory.rdar://98835746