Add += operator for Trivia
#612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
fwcd
force-pushed
the
tokens-plus-assign
branch
from
6932ed3 to
27c3404
Compare
|
@swift-ci please test |
ahoppen
reviewed
Aug 20, 2022
Sources/SwiftSyntax/Trivia.swift.gyb
Outdated
Comment on lines
218
to
224
| /// Concatenates two collections of `Trivia` into the left-hand side. | ||
| public func +=(lhs: inout Trivia, rhs: Trivia) { | ||
| lhs = lhs + rhs | ||
| } | ||
|
|
There was a problem hiding this comment.
I have a vague memory that from a type checking performance perspective, it’s better to implement these as static methods inside the Trivia type itself.
Suggested change
| /// Concatenates two collections of `Trivia` into the left-hand side. | |
| public func +=(lhs: inout Trivia, rhs: Trivia) { | |
| lhs = lhs + rhs | |
| } | |
| extension Trivia { | |
| /// Concatenates two collections of `Trivia` into the left-hand side. | |
| public static func +=(lhs: inout Trivia, rhs: Trivia) { | |
| lhs = lhs + rhs | |
| } | |
| } | |
There was a problem hiding this comment.
Does this apply to the + operator too?
There was a problem hiding this comment.
It used to, but we removed the designated types optimization that supported it. Now it should mostly a hygiene thing, and from that perspective I agree with Alex that this should be in extension context.
fwcd
force-pushed
the
tokens-plus-assign
branch
from
27c3404 to
3b1d6c8
Compare
|
@swift-ci please test |
CodaFi
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small convenience that makes it more convenient to construct
Triviaimperatively.