Move SwiftSyntaxParser related code to its own module #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
syntaxparser-move
branch
3 times, most recently
from
705acf9 to
8eeb394
Compare
rintaro
commented
Aug 19, 2022
| @@ -286,6 +287,3 @@ extension Diagnostic { | |||
| } | |||
| } | |||
|
|
|||
| fileprivate func verifyCNodeLayoutHash() -> Bool { | |||
| return cNodeLayoutHash() == SwiftSyntax.cNodeLayoutHash() | |||
There was a problem hiding this comment.
Now that SwiftSyntax doesn't know anything about CNodes, so this is not needed anymore.
|
@swift-ci Please test |
rintaro
force-pushed
the
syntaxparser-move
branch
4 times, most recently
from
105fcc8 to
9ecba2b
Compare
ahoppen
reviewed
Aug 20, 2022
| guard var ptr = buffer.baseAddress else { return } | ||
| for cnode in cnodes { | ||
| let element: RawSyntax? = cnode.map { | ||
| // 'CClinentNode' is a node created with `toOpaque()` |
There was a problem hiding this comment.
Typo
Suggested change
| // 'CClinentNode' is a node created with `toOpaque()` | |
| // 'CClientNode' is a node created with `toOpaque()` |
| let syntaxKind = SyntaxKind(serializationCode: cnode.kind) | ||
| assert(syntaxKind != .token) | ||
|
|
||
| let cnodes = UnsafeBufferPointer<CClientNode?>( |
There was a problem hiding this comment.
Maybe call cnodes children instead?
ahoppen
approved these changes
Aug 20, 2022
CodaFi
approved these changes
Aug 20, 2022
* Remove `_SyntaxParserInterop.swift` * Use `RawSyntax.toOpaque()`/`RawSyntax.fromOpaque(:_)` to interop * Move `RawSyntax.createFromCSyntaxNode()` to the module * Move SyntaxKind/RawTokenKind/RawTriviaPiece creation from C serialization code to the module * Tweak some RawSyntax API visibility * Refactor materialized token creation API to efficiently create a them from the parser modules * Introduce `Syntax.withUnsafeRawSyntax(_:)` API
rintaro
force-pushed
the
syntaxparser-move
branch
from
9ecba2b to
6bcf9fd
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_SyntaxParserInterop.swiftRawSyntax.toOpaque()/RawSyntax.fromOpaque(:_)to interopRawSyntax.createFromCSyntaxNode()to the moduleSyntax.withUnsafeRawSyntax(_:)API