Skip to content

Add two more diagnostics #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Add two more diagnostics #624

merged 2 commits into from
Aug 25, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 23, 2022

  • Emit specialized diagnostic for functions without parameters
  • Add contextual diagnostic message if colon is missing in ternary expression

rdar://98745337
rdar://98724207

@ahoppen ahoppen requested review from bnbarham and CodaFi August 23, 2022 08:39
@ahoppen
Copy link
Member Author

ahoppen commented Aug 23, 2022

@swift-ci Please test

return .visitChildren
}

public override func visit(_ node: TernaryExprSyntax) -> SyntaxVisitorContinueKind {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be Unresolved... now?

@ahoppen
Copy link
Member Author

ahoppen commented Aug 24, 2022

@swift-ci Please test

@ahoppen ahoppen merged commit c4dc91e into swiftlang:main Aug 25, 2022
@ahoppen ahoppen deleted the pr/more-diags branch January 14, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants