Fix parser issues found by asserting that self-parsing should not produce diagnostics #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren’t consuming the right parenthesis after skipping an attribute.
… a regex literal for the new parser
|
@swift-ci Please test |
CodaFi
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flip the switch on
AssertParseto check that no diagnostics are produced by default. Also check that no diagnostics are produced during the self-parse.Making this change required two changes to:
)while skipping attributesswift-parser-test.swiftto disambiguate it as not being parsed as a regex literal (rdar://98736315)In a follow-up PR, I will change the
AssertParsestatements that nowallowErrorsto check that the correct diagnostics are produced.rdar://98575270