Get rid of XXXSyntax.Cursor type
#630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are internal types which served as layout 'subscript' keys e.g.
`layout[Cursor.propertyName]`. That looks nice, but in reality, the
name is usually written very close:
var propertyName: PropertyType {
get { layout[Cursor.propertyName] }
}
So it didn't give us much benefit. In the contrary, it hid the "index"
information which might be useful when investigating issues. So just get
rid of them for now.
Since they are just internal types. So no external API changes.
|
@swift-ci Please test |
ahoppen
approved these changes
Aug 23, 2022
|
Maybe it's convenient for getting a property name from an index? Like extension FunctionDeclSyntax {
static func propertyName(at i: Int) -> String {
switch i {
case 0: return "unexpectedBeforeAttributes"
case 1: return "attributes"
...
}
}
}or similar when we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are internal types which served as layout 'subscript' keys e.g.
layout[Cursor.propertyName]. That looks nice, but in reality, the name is usually written very close, like:So it didn't give us much benefit. In the contrary, it hid the actual "index" information which might be useful when investigating issues. So just get rid of them for now.
Since they are just internal types, there's no external API changes.