Fix crash on nested interpolation #637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #618, #636
Lex.Cursor.skipToEndOfInterpolatedExpression
is called from two paths.One is from
Lexer.Cursor.lexStringLiteral
.Another is from
Lexer.lexToEndOfInterpolatedExpression
fromParser.parseStringLiteralSegments
.In first case, cursor position is after of
(
which opens interpolation.But
skipToEndOfInterpolatedExpression
expects it called on position of(
.So Lexer split tokens wrongly with some inputs.
For example:
Lexer closes interpolation (1) wrongly. (2) is correct.
To fix this issue, I change
lexStringLiteral
.As changing
advance
topeek
,cursor position is on
(
when it callsskipToEndOfInterpolatedExpression
.