Add tests for already fixed issues #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, nice. Those are always the best issues that have already been fixed. 👍 I just merged #641 that changes the You don’t need to worry about the quality of the generated diagnostics at this point, I’ll do some basic work on general diagnostic quality in the week(s). If you think the diagnostics are sub-optimal, just add a FIXME for now. |
|
OK, I edit my PR to use new checking for specific diagnostics. |
|
@ahoppen I updated PR. |
omochi
force-pushed
the
add-fixed-issues-test
branch
from
6b11622 to
c6e1431
Compare
|
@swift-ci test |
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to fix issues #632 and #634.
But it seems to be already fixed.
I added test cases for them.