Add default leading and trailing trivia to tokens from Format
#651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
fwcd
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Looks good, a minor stylistic note below.
The only thing that I am a bit concerned about is that this regresses generation time slightly (9 s on main vs 12 s on this branch, with a debug build on my machine), probably due to the additional withXTrivia calls. Since token generation is usually on the hot path and happens pretty often, even small changes can have an impact there.
In any case that is probably for another PR.
| } | ||
| } | ||
|
|
||
| func createWithLeadingWithTrailingTriviaCall(token: TokenSpec) -> CodeBlockItem { |
There was a problem hiding this comment.
Can we make this private?
Suggested change
| func createWithLeadingWithTrailingTriviaCall(token: TokenSpec) -> CodeBlockItem { | |
| private func createWithLeadingWithTrailingTriviaCall(token: TokenSpec) -> CodeBlockItem { |
This frees `TokenSyntax` from any implicit formatting and sinks all formatting logic into the `Format` type for a clearer separation of concerns.
ahoppen
force-pushed
the
ahoppen/token-format
branch
from
3b2e747 to
f5e146e
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This frees
TokenSyntaxfrom any implicit formatting and sinks all formatting logic into theFormattype for a clearer separation of concerns.