Store presence of a token in an explicit field #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
reviewed
Aug 29, 2022
| kind: kind, text: "", leadingTriviaPieces: [], trailingTriviaPieces: [], | ||
| arena: arena) | ||
| kind: kind, | ||
| text: "", |
There was a problem hiding this comment.
Inconsistent with RawSyntax.makeMissingToken(). Should we use kind.defaultText here?
There was a problem hiding this comment.
I did actually change that in some follow-up PR but it looks like it didn’t make it into this PR. Updated it now.
ahoppen
force-pushed
the
ahoppen/token-presence
branch
from
b6ec295 to
3f15898
Compare
rintaro
approved these changes
Aug 30, 2022
We recently changed a token’s presence to be implicitly determined by whether it contains any source code. It turns out that this has two downsides: - We cannot synthesize missing tokens with explicitly known text, like a missing `for` identifier token for the `@_dynamicReplacable` attribute - We cannot synthesize missing tokens with trivia
ahoppen
force-pushed
the
ahoppen/token-presence
branch
from
3f15898 to
5ceea93
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently changed a token’s presence to be implicitly determined by whether it contains any source code. It turns out that this has two downsides:
foridentifier token for the@_dynamicReplacableattribute (this is the issue that I just stumbled over)