Remove recover methods from the parser
#655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/no-legacy-recovery
branch
from
cb63b7f to
43b1b42
Compare
ahoppen
force-pushed
the
ahoppen/no-legacy-recovery
branch
from
43b1b42 to
b8a0e43
Compare
Recovery should be handled as unexpected nodes, which are usually produced by `expect`.
ahoppen
force-pushed
the
ahoppen/no-legacy-recovery
branch
from
b8a0e43 to
42c3af5
Compare
|
@swift-ci Please test |
CodaFi
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sticking unexpected tokens into
errorTokensof aCodeBlock, we should be putting them into the tree as unexpected nodes, where they can be diagnosed. These unexpected nodes are typically created byParser.expectcalls.