Skip to content

Use swift-argument-parser in generate-swift-syntax-builder #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Sep 2, 2022

This branch updates generate-swift-syntax-builder to use swift-argument-parser instead of ad-hoc parsing CommandLine.arguments.

Since the package already depends on swift-argument-parser for swift-parser-test I would not expect the introduction of this new target dependency to be an issue, but perhaps still worth checking whether there are any unexpected bootstrapping consequences to this.

@fwcd fwcd requested a review from ahoppen as a code owner September 2, 2022 11:06
@fwcd
Copy link
Member Author

fwcd commented Sep 2, 2022

@swift-ci please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that there should not be any issues associated with using swift-argument-parser for generate-swift-syntax-builder. The important bit is that we would still be able to build SwiftParser without depending on swift-argument parser.

@fwcd
Copy link
Member Author

fwcd commented Sep 2, 2022

@swift-ci please test

@fwcd fwcd merged commit 5dbf470 into swiftlang:main Sep 2, 2022
@fwcd fwcd deleted the fwcd/generate-ssb-argument-parser branch September 2, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants