Skip to content

Re-parent the Unexpected Nodes in Function Types #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Sep 6, 2022

Function type parsing does this awkward dance where it peels apart tuple
types before arrows and re-inserted them into function type syntax nodes.
Take the unexpected nodes into account during this transformation.

Fixes #680

Function type parsing does this awkward dance where it peels apart tuple
types before arrows and re-inserted them into function type syntax nodes.
Take the unexpected nodes into account during this transformation.

Fixes swiftlang#680
@CodaFi CodaFi requested a review from ahoppen as a code owner September 6, 2022 15:57
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 6, 2022

@swift-ci test

@CodaFi CodaFi merged commit ac6f92b into swiftlang:main Sep 6, 2022
@CodaFi CodaFi deleted the typing-test branch September 6, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round-trip failure with trailing arrow
1 participant