Closure Parsing Omnibus #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsing Fixes swiftlang#725 rdar://99669872
Fix a regression where we didn't recognize unowned(safe) in closure captures. Fixes swiftlang#722 rdar://99657725
Make XCTest point at the actual expectation that failed, not the call to AssertParse
All the lookahead we did before this promised us a right bracket here, but the precedence of right brackets is too weak to overcome keywords. The attached test case shows that we fall all the way through closure signature parsing and nothing picks up the slack and eats the remaining parts of the signature. Instead, do `expect`'s job for it and try to munge through to the right bracket ourselves. Fixes swiftlang#721 rdar://99657721
|
@swift-ci test |
CodaFi
added a commit
to CodaFi/swift-syntax
that referenced
this pull request
Sep 8, 2022
This was resolved by swiftlang#727 rdar://99430613
jpsim
pushed a commit
to jpsim/swift-syntax
that referenced
this pull request
Sep 11, 2022
This was resolved by swiftlang#727 rdar://99430613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #725, #721, and #722