Miscellaneous parser fixes #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
CodaFi
approved these changes
Sep 8, 2022
ahoppen
reviewed
Sep 8, 2022
| func testRethrowsAttribute() { | ||
| AssertParse( | ||
| """ | ||
| @rethrows |
There was a problem hiding this comment.
Is @rethrows a valid attribute? Do we need to handle @try or other keywords as well?
There was a problem hiding this comment.
Yeah, @rethrows is a valid attribute, which applies only to protocols. It should have been an underscored feature because it's not really done yet, but we messed up.
There was a problem hiding this comment.
I see. In that case you probably want to remap rethrows to an identifier when consuming it, right?
There was a problem hiding this comment.
That's a great point! I'll do that in a follow-up PR.
There was a problem hiding this comment.
Finally did this: #818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a number of small issues encountered while parsing the standard library:
/a)/)@rethrowsattribute#fileID@differentiableon types